Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
…tionfunctionwithsentry
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| normalizedRequest: { | ||
| headers: headersDict, | ||
| } satisfies RequestEventData, | ||
| }); |
There was a problem hiding this comment.
Navigation errors incorrectly captured when no span exists
High Severity
The shouldCapture variable defaults to true, but the logic that sets it to false for not-found and redirect navigation errors is nested inside if (span). When getActiveSpan() returns undefined (no active span), the navigation error checks are skipped entirely, causing captureException to be called for these expected navigation behaviors. This results in erroneous error reports to Sentry for redirects and 404s that should be silently ignored.
chargome
deleted the
cg/JS-1424/remove-tracing-from-wrapgenerationfunctionwithsentry
branch
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18731